search

aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
9 stars 14 forks source link

assgin clean_workdir to plugin's builder #667

Closed superstar54 closed 2 months ago

superstar54 commented 2 months ago

fix #666

If a plugin has clean_workdir default to True, even if the user didn't select the clean_workdir box, the plugin still cleans the workdir. This PR assigns the clean_workdir to the plugin's builder to make sure the clean_workdir is consistent.

AndresOrtegaGuerrero commented 2 months ago

@superstar54 before you merge, do we have a test, to check if the builder set the clean_workdir ? in the workchains ?

superstar54 commented 2 months ago

do we have a test, to check if the builder set the clean_workdir ? in the workchains ?

For all the plugins we have (bands, pdos, xas, xps etc), I think the default clean_workdir is False, so we can not make a test using them. But I test this using the aiida-quantumespresso-hp, which has a clean_workdir default to be True, and it works.

AndresOrtegaGuerrero commented 2 months ago

do we have a test, to check if the builder set the clean_workdir ? in the workchains ?

For all the plugins we have (bands, pdos, xas, xps etc), I think the default clean_workdir is False, so we can not make a test using them. But I test this using the aiida-quantumespresso-hp, which has a clean_workdir default to be True, and it works.

Is it possible to just check the generated builder , to check when set clean_workdir is true ? is not then is ok , you can merge.

superstar54 commented 2 months ago

Is it possible to just check the generated builder , to check when set clean_workdir is true ? is not then is ok , you can merge.

Yes, one can check the builder. But the builder test has been removed from this PR #https://github.com/aiidalab/aiidalab-qe/pull/644. We will add a new builder test in the future.