aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
11 stars 14 forks source link

Add bumpver pre-commit #688

Closed danielhollas closed 5 months ago

danielhollas commented 5 months ago

This is the last piece in the release workflow.

The newly added bumpver_pre_commit.sh script is configured to run automatically by bumpver before it creates the release commit. We check for common mistakes, such as making a release commit in a wrong branch, or trying to push to a wrong remote.

For now, only two checks are implemented:

  1. Check that the current branch name matches either release/* or support/*

  2. Check that the remote origin is pointing to the origin repository, and not a fork. Note however that this assumes that origin is the default remote where new branches are pushed. If the user configured a different default remote, this check will not save them in the current implementation.

Future work:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.79%. Comparing base (f63da7d) to head (8022f49). Report is 73 commits behind head on main.

:exclamation: Current head 8022f49 differs from pull request most recent head 00873c0. Consider uploading reports for the commit 00873c0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #688 +/- ## ========================================== - Coverage 80.73% 75.79% -4.95% ========================================== Files 49 59 +10 Lines 3415 4767 +1352 ========================================== + Hits 2757 3613 +856 - Misses 658 1154 +496 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/688/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/688/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `75.79% <ø> (-4.95%)` | :arrow_down: | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/688/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `?` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/688/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 5 months ago

@unkcpz @superstar54 friendly ping (I know you're busy) to review this so that we can start testing this for the releases. Thanks!

danielhollas commented 5 months ago

@superstar54 thanks for taking a look. Feel free to merge so you can test it while doing releases. I think you will want to recreate the rc2 release PR #701 anyway to pick up the most recent commits on main, so this might be a good opportunity for a test.