Closed danielhollas closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.79%. Comparing base (
f63da7d
) to head (8022f49
). Report is 73 commits behind head on main.:exclamation: Current head 8022f49 differs from pull request most recent head 00873c0. Consider uploading reports for the commit 00873c0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@unkcpz @superstar54 friendly ping (I know you're busy) to review this so that we can start testing this for the releases. Thanks!
@superstar54 thanks for taking a look. Feel free to merge so you can test it while doing releases. I think you will want to recreate the rc2 release PR #701 anyway to pick up the most recent commits on main, so this might be a good opportunity for a test.
This is the last piece in the release workflow.
The newly added
bumpver_pre_commit.sh
script is configured to run automatically by bumpver before it creates the release commit. We check for common mistakes, such as making a release commit in a wrong branch, or trying to push to a wrong remote.For now, only two checks are implemented:
Check that the current branch name matches either
release/*
orsupport/*
Check that the remote
origin
is pointing to the origin repository, and not a fork. Note however that this assumes thatorigin
is the default remote where new branches are pushed. If the user configured a different default remote, this check will not save them in the current implementation.Future work:
release/*
branches, notsupport/*
branchescheck what is the default push branch
It would be great if at least some of these checks were handled by bumpver itself:
Restricting releases from branch: https://github.com/mbarkhau/bumpver/issues/198 Restricting releases to specified remote: https://github.com/mbarkhau/bumpver/issues/234