search

aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
11 stars 14 forks source link

Bump version v24.04.0rc2 -> v24.04.0rc3 #714

Closed superstar54 closed 5 months ago

superstar54 commented 5 months ago

Close as new commits have been added to the main branch.

superstar54 commented 5 months ago

Hi @danielhollas , in this case, I should close this PR and make a new PR from the latest main branch, right?

What if I want to make a release from a commit instead of the latest main? Is it possible to use the current release workflow?

danielhollas commented 5 months ago

Hi @danielhollas , in this case, I should close this PR and make a new PR from the latest main branch, right?

Yep

What if I want to make a release from a commit instead of the latest main? Is it possible to use the current release workflow?

Sure, you just have to branch out from that commit. What use case would you have in mind then?

superstar54 commented 5 months ago

Sure, you just have to branch out from that commit.

But when I merge the PR to the main, will there conflict? I think I need to update the branch from main branch before the merge

superstar54 commented 5 months ago

One question: After I run bumpver update—-set-version v24.04.0rc3 and make a PR, I already see the branch and tag for v2024.04.0rc3, and I can also see it in the App Store before merging the PR. I am confused about the meaning of merging the PR.