search

aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
9 stars 14 forks source link

Adding the max_wallclock_seconds setting #743

Closed mikibonacci closed 1 month ago

mikibonacci commented 1 month ago

Addressing https://github.com/aiidalab/aiidalab-qe/issues/709

I have to fix the layout, but in the meanwhile useful to see if there is some major issue.

superstar54 commented 1 month ago

@mikibonacci please fix the failed tests.

AndresOrtegaGuerrero commented 1 month ago

@mikibonacci i think you are also trying to upload the export folder

AndresOrtegaGuerrero commented 1 month ago

@mikibonacci is it possible to add a test for this option?

mikibonacci commented 1 month ago

Sure, I will add a test. About the export folder, I will check what is happening, I am not sure

mikibonacci commented 1 month ago

@AndresOrtegaGuerrero, I am not sure we need a test for this setting? I adapted the test_qeapp_computational_resources_widget function to include also the test for the time. Do you have suggestion on specific tests?

AndresOrtegaGuerrero commented 1 month ago

@AndresOrtegaGuerrero, I am not sure we need a test for this setting? I adapted the test_qeapp_computational_resources_widget function to include also the test for the time. Do you have suggestion on specific tests?

Maybe a for the builder , just to confirm that the builder is indeed generating the walltime change

mikibonacci commented 1 month ago

@AndresOrtegaGuerrero my last commit should be the one to put also the check for the builder. If it is enough for you, I would like to merge