search

aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
11 stars 14 forks source link

Deleting the diamond.cif file #757

Closed mikibonacci closed 3 months ago

mikibonacci commented 3 months ago

This will give case-insensitive problems with Diamond.cif - this will happen only for case-insensitive filesystems like my Mac. The problem is that then is it not possible to clone the repo without having to choose (git does it) among the two files.

The diamond.cif file seems anyway not used, so we do not need it.

This will solve https://github.com/aiidalab/aiidalab-qe/issues/756.

superstar54 commented 3 months ago

Hi @mikibonacci , thanks for the fix!

The test failed because of the wrong setup.cfg in one of the dependence aiidalab-eln. I made a PR to aiidalab-eln to fix it.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.28%. Comparing base (39d411b) to head (46cf7fe). Report is 33 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #757 +/- ## ======================================= Coverage 68.28% 68.28% ======================================= Files 45 45 Lines 4143 4143 ======================================= Hits 2829 2829 Misses 1314 1314 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/757/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `68.28% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `68.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.