aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
12 stars 14 forks source link

Restore update results button functionality #924

Closed edan-bainglass closed 1 week ago

edan-bainglass commented 1 week ago

The logic of the update results button was missed in #921. This PR restores the functionality by adding a refresh parameter to the _update_node_view method to allow bypassing the node view cache.

Note: a follow-up PR is planned to rethink the way we deal with the WorkChainViewer tabs which will render the update results button redundant.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (5a55a5c) to head (8ccae82). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/result/__init__.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #924 +/- ## ========================================== + Coverage 66.92% 66.94% +0.01% ========================================== Files 51 51 Lines 4726 4725 -1 ========================================== Hits 3163 3163 + Misses 1563 1562 -1 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `66.94% <33.33%> (+0.01%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `66.97% <33.33%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.