aiidalab / aiidalab-qe

AiiDAlab App for Quantum ESPRESSO
https://aiidalab-qe.readthedocs.io/
MIT License
12 stars 14 forks source link

Bandswidget refactoring #941

Open AndresOrtegaGuerrero opened 7 hours ago

AndresOrtegaGuerrero commented 7 hours ago

In this PR, I am refactoring the BandsPdosWidget in order to only create the plot once , and apply updates using the helper in the model

codecov[bot] commented 3 hours ago

Codecov Report

Attention: Patch coverage is 47.87234% with 49 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (363be6f) to head (90e661c).

Files with missing lines Patch % Lines
src/aiidalab_qe/common/bands_pdos/model.py 36.84% 24 Missing :warning:
src/aiidalab_qe/common/bands_pdos/utils.py 17.64% 14 Missing :warning:
...rc/aiidalab_qe/common/bands_pdos/bandpdoswidget.py 57.14% 9 Missing :warning:
...rc/aiidalab_qe/common/bands_pdos/bandpdosplotly.py 88.88% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #941 +/- ## ========================================== - Coverage 68.40% 68.02% -0.38% ========================================== Files 110 110 Lines 6096 6127 +31 ========================================== - Hits 4170 4168 -2 - Misses 1926 1959 +33 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/941/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `?` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-qe/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `68.02% <47.87%> (-0.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: