Fix: Do not assume Selection tab in StructureDataViewer

[danielhollas]

Passing an empty configuration_tabs to StructureDataViewer would throw a ValueError, because the code would assume that the Selection tab is always present.

[unkcpz]

Thanks @danielhollas.

Passing an empty configuration_tabs to StructureDataViewer

Do you mean passing None to configuration_tabs? Since there is the if len(configuration_tabs) != 0: to exclude the empty list. But the None is passing to the variable is catch the previous lines above. I can not see the problem that the issue caused.

[unkcpz]

I see your point now. If passing a list without Selection would cause the issue. Just have one minor request. All is good then.

[danielhollas]

Thanks @unkcpz! As this is currently blocking a feature I am working on, would you mind publishing a new 1.4.x version? There have been a couple of other fixes since last version as well.

[unkcpz]

No problem, I’ll do it tomorrow when I back to office.

On Tue, 1 Nov 2022 at 18:48, Daniel Hollas @.***> wrote:

Thanks @unkcpz https://github.com/unkcpz! As this is currently blocking a feature I am working on, would you mind publishing a new 1.4.x version? There have been a couple of other fixes since last version as well.

— Reply to this email directly, view it on GitHub https://github.com/aiidalab/aiidalab-widgets-base/pull/379#issuecomment-1298892237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDMFROOESAQGNTPPBP24M3WGFJXVANCNFSM6AAAAAARTTUXYY . You are receiving this because you were mentioned.Message ID: @.***>

[unkcpz]

Hi @danielhollas, I invite you to our aiidalab app slack channel, feel free to join.

[unkcpz]

@danielhollas 1.4.2 is released.