search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Using new code create API #394

Closed unkcpz closed 1 year ago

unkcpz commented 1 year ago

Closes #393

unkcpz commented 1 year ago

This will still have one Code deprecation warning but rooted from aiida-core as mentioned by @sphuber today, I think we can not do anything from the AiiDAlab side.

yakutovicha commented 1 year ago

I am so annoyed by those random readthedocs failures.

danielhollas commented 1 year ago

Looking at the error, it looks like the distutils issue that @unkcpz mentioned on Slack, and that is explained in aiida-core as well

https://github.com/aiidateam/aiida-core/pull/5782

EDIT: I guess this will get solved once we move to pyproject.toml and flit

https://github.com/aiidalab/aiidalab-widgets-base/pull/390#issuecomment-1321858272

unkcpz commented 1 year ago

I am so annoyed by those random readthedocs failures.

As @danielhollas said, yes, I think this will be fixed by pining the setuptools version, but we are going to move to pyproject.toml and we 'll do it after that. So maybe we can ignore the failed DOC build failure at the moment?