search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Take screenshots in notebook tests and upload them as artifacts #411

Closed danielhollas closed 1 year ago

danielhollas commented 1 year ago

@unkcpz here I took an alternative approach that you suggested at the QeApp PR, where I am using chmod instead of chown to fix AWB directory permissions inside the test container.

unkcpz commented 1 year ago

Can you also show here the pytest warnings before and after this fix? I am still not sure why we need the write access for pytest.

danielhollas commented 1 year ago

The write access is mainly needed for pip install.

Pytest tries to write some kind of cache into .cache, you should see the warnings in any CI run outside of this PR. But it doesn't seem to be crucial.

danielhollas commented 1 year ago

@unkcpz thanks for the review. :pray: I've incorporated your suggestions and further tweaked the screenshots. Some tests need to be improved but that's for another PR. This is good to go from my side. :rocket: