search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Manifest the issue of setting multiple codes #415

Closed unkcpz closed 1 year ago

unkcpz commented 1 year ago

fixes #416

unkcpz commented 1 year ago

Was this bug introduced during the migration, or was it there before?

I think it will not raised previously, it was introduced by https://github.com/aiidalab/aiidalab-widgets-base/pull/410, the last commit I added to bring the _configure_computer back. In the previous case, if no SSH username was provided, the computer still get setup and configured but setting SSH again will not make it work afterward. Because the computer configuration need the SSH username updated.

Thanks for the new tests, I assume they would fail before the fix.

Yes, it would fail. This is the very positive side to have such a test framework. What a relief!