search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Tests: Get screenshot at test teardown - approach 2 #422

Closed danielhollas closed 1 year ago

danielhollas commented 1 year ago

This is an alternative PR to #421, see that PR for a detailed problem description. These two PRs should be reviewed together and it should be decided which approach is preferred.

Here to take a final screenshot, we modify the existing selenium_driver fixture. Screenshot name is passed in as an optional parameter when getting the driver.

I don't have a strong preference. I think a like the approach in #421 (having a dedicated new screenshot fixture) a bit more, because selenium_driver fixture is already quite busy and here we're making it more complicated.

Closes #419

danielhollas commented 1 year ago

Looks like approach in #421 is preferred so I will close this.