search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Selection should get cleared when a new structure set #431

Open danielhollas opened 1 year ago

danielhollas commented 1 year ago

I noticed a further regression in my tests, here's the procedure:

  1. Generate a methane molecule

  2. Select the the first atom

  3. Check that the first atom is selected and is Carbon (matching the text "Id: 1; Symbol: O") Here's how it looks now: image

  4. Generate a new molecule (NH3) At this point, the UI looks the same as on the screenshot above. Instead, I would assume that it should get automatically cleared.

  5. Select the first atom :negative_squared_cross_mark: This step fails. After clicking the Apply selection button, the selection is not updated. This is definitely unexpected. Only when I changed the selection (e.g. try to select second atom), or if I click Clear Selection, only then it gets updated.

yakutovicha commented 1 year ago

I assume this is already fixed as a part of https://github.com/aiidalab/aiidalab-widgets-base/pull/373. I keep it open until #373 is merged and we get the confirmation that things work as expected.

I moved it to the next milestone 2.1.0.