search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

NodeTreeWidget: Add input nodes #432

Open danielhollas opened 1 year ago

danielhollas commented 1 year ago

Currently in the tree, we only show the output nodes in the outputs directory of a given workchain. Sometimes it is very useful for debugging to see exactly how the input nodes look like. Therefore I propose we add the inputs directory.

This should be relatively easy, we just need to generalize the code that adds the output nodes.

https://github.com/aiidalab/aiidalab-widgets-base/blob/149a249eff5cb888ed455f16c99cc9a0ce0a6f8f/aiidalab_widgets_base/nodes.py#L102

See also corresponding discussion on the QeApp. https://github.com/aiidalab/aiidalab-qe/issues/352

danielhollas commented 1 year ago

@unkcpz any thoughts on this? I think I'd like to tackle this in a relatively near future. I need to solve some performance issues with the NodeTree widget, and this looks like an easier issue to tackle first to get familiar with the widget.

unkcpz commented 1 year ago

That would be great if you can have a look at it! I need to remind the variable naming convention is very nasty in this widget, maybe you can start from standardize it. The "node" of the node tree is confusing with the AiiDA node concept in this widget, which makes it very buggy.