search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

process followers widget need interface updated #433

Closed unkcpz closed 1 year ago

unkcpz commented 1 year ago

When running process.ipynb with a real process, the exception raised that the interface calling ProcessMonitorWidget is incorrect. I update the ProcessFollowerWidget interface to use the value for process uuid as well. This brings the issue https://github.com/aiidalab/aiidalab-widgets-base/issues/426 to more higher priority that we what having all such widget have a new interface which is more designable in my opinion.

danielhollas commented 1 year ago

Thanks @unkcpz. I've added a "blocked" label until we discuss this issue more generally. The question to me is whether we want to make further breaking changes or not. The fix in this PR can certainly be done in a way that doesn't break existing apps.

unkcpz commented 1 year ago

Okay, no problem. Let's find time to discuss this with @yakutovicha together. I'll separate some pre-commit fixes out and make a separate PR.

danielhollas commented 1 year ago

@unkcpz can you create a corresponing issue for this and add it to the 2.0.0 milestone?

unkcpz commented 1 year ago

This is Superseded by https://github.com/aiidalab/aiidalab-widgets-base/pull/455