aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Add tests for `computational_resources` module. #448

Closed yakutovicha closed 1 year ago

yakutovicha commented 1 year ago

fixes #447

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.87% and project coverage change: +10.81 :tada:

Comparison is base (130457e) 39.69% compared to head (74f4751) 50.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #448 +/- ## =========================================== + Coverage 39.69% 50.50% +10.81% =========================================== Files 20 21 +1 Lines 3162 3249 +87 =========================================== + Hits 1255 1641 +386 + Misses 1907 1608 -299 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `50.50% <98.87%> (+10.81%)` | :arrow_up: | | python-3.8 | `50.53% <98.87%> (+10.83%)` | :arrow_up: | | python-3.9 | `50.53% <98.87%> (+10.83%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [aiidalab\_widgets\_base/\_\_init\_\_.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [aiidalab\_widgets\_base/computational\_resources.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL2NvbXB1dGF0aW9uYWxfcmVzb3VyY2VzLnB5) | `70.55% <83.33%> (+51.15%)` | :arrow_up: | | [tests/conftest.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvY29uZnRlc3QucHk=) | `63.04% <100.00%> (+1.24%)` | :arrow_up: | | [tests/test\_computational\_resources.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvdGVzdF9jb21wdXRhdGlvbmFsX3Jlc291cmNlcy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/448/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielhollas commented 1 year ago

Just FYI there is this known bug for creating a new localhost computer. Not sure if you've run into it while testng

https://github.com/aiidalab/aiidalab-widgets-base/issues/417

I'll leave this review to @unkcpz since he's been working on this widget a lot.

yakutovicha commented 1 year ago

Just FYI there is this known bug for creating a new localhost computer. Not sure if you've run into it while testng

I prefer to fix that bug in a follow-up PR.