aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Add tests to the viewers module and slightly improve its styling #450

Closed yakutovicha closed 1 year ago

yakutovicha commented 1 year ago

fixes #449

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.38% and project coverage change: +5.62 :tada:

Comparison is base (ef677ac) 56.31% compared to head (8dd1621) 61.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #450 +/- ## ========================================== + Coverage 56.31% 61.93% +5.62% ========================================== Files 21 22 +1 Lines 3326 3381 +55 ========================================== + Hits 1873 2094 +221 + Misses 1453 1287 -166 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `61.93% <90.38%> (+5.62%)` | :arrow_up: | | python-3.8 | `61.97% <90.38%> (+5.62%)` | :arrow_up: | | python-3.9 | `61.97% <90.38%> (+5.62%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [aiidalab\_widgets\_base/viewers.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL3ZpZXdlcnMucHk=) | `69.43% <75.60%> (+19.74%)` | :arrow_up: | | [tests/conftest.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvY29uZnRlc3QucHk=) | `71.66% <100.00%> (+8.62%)` | :arrow_up: | | [tests/test\_viewers.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvdGVzdF92aWV3ZXJzLnB5) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/450/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.