aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Test and update process module #455

Closed yakutovicha closed 1 year ago

yakutovicha commented 1 year ago

fixes #454

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.61% and project coverage change: +8.29 :tada:

Comparison is base (cc17af7) 61.93% compared to head (92967f9) 70.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 61.93% 70.22% +8.29% ========================================== Files 22 22 Lines 3381 3490 +109 ========================================== + Hits 2094 2451 +357 + Misses 1287 1039 -248 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `70.22% <96.61%> (+8.29%)` | :arrow_up: | | python-3.8 | `?` | | | python-3.9 | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [aiidalab\_widgets\_base/process.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL3Byb2Nlc3MucHk=) | `78.58% <90.76%> (+45.25%)` | :arrow_up: | | [tests/conftest.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvY29uZnRlc3QucHk=) | `76.22% <100.00%> (+4.55%)` | :arrow_up: | | [tests/test\_process.py](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-dGVzdHMvdGVzdF9wcm9jZXNzLnB5) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielhollas commented 1 year ago

Just a quick general comment, could you devise a test that would uncover the issue in #433. You can then mark it with xfail and we fix it in another PR, but I think it's important to think about it here to uncover other potential problems.

unkcpz commented 1 year ago

@danielhollas thanks for the head up. I open an issue https://github.com/aiidalab/aiidalab-widgets-base/issues/456 It can be tested and fixed here.

yakutovicha commented 1 year ago

Just a quick general comment, could you devise a test that would uncover the issue in #433. You can then mark it with xfail and we fix it in another PR, but I think it's important to think about it here to uncover other potential problems.

@danielhollas thanks for the head up. I open an issue #456 It can be tested and fixed here.

Thanks, guys. Indeed, I make those series of PRs as a byproduct of manual testing. The goal is to make sure that at least the basics are tested.

For more in-depth stuff, I would divert to separate issues/PRs to allow better focus on the specific widget that requires special attention. Just to avoid delays with a release.

yakutovicha commented 1 year ago

Thanks @yakutovicha. The tests for process widget seems not actually test the interaction with widget. I think when those widget gets process traitlets updated, must come with some text of the sub-widget updated.

In the places where it makes more sense, I updated some of the widgets to follow the process status "live".