Closed yakutovicha closed 1 year ago
Patch coverage: 96.61
% and project coverage change: +8.29
:tada:
Comparison is base (
cc17af7
) 61.93% compared to head (92967f9
) 70.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Just a quick general comment, could you devise a test that would uncover the issue in #433. You can then mark it with xfail
and we fix it in another PR, but I think it's important to think about it here to uncover other potential problems.
@danielhollas thanks for the head up. I open an issue https://github.com/aiidalab/aiidalab-widgets-base/issues/456 It can be tested and fixed here.
Just a quick general comment, could you devise a test that would uncover the issue in #433. You can then mark it with
xfail
and we fix it in another PR, but I think it's important to think about it here to uncover other potential problems.@danielhollas thanks for the head up. I open an issue #456 It can be tested and fixed here.
Thanks, guys. Indeed, I make those series of PRs as a byproduct of manual testing. The goal is to make sure that at least the basics are tested.
For more in-depth stuff, I would divert to separate issues/PRs to allow better focus on the specific widget that requires special attention. Just to avoid delays with a release.
Thanks @yakutovicha. The tests for process widget seems not actually test the interaction with widget. I think when those widget gets process traitlets updated, must come with some text of the sub-widget updated.
In the places where it makes more sense, I updated some of the widgets to follow the process status "live".
fixes #454