Closed yakutovicha closed 1 year ago
Patch coverage: 96.42
% and project coverage change: +0.16
:tada:
Comparison is base (
b99d88d
) 79.32% compared to head (98717e5
) 79.48%.:exclamation: Current head 98717e5 differs from pull request most recent head f31b187. Consider uploading reports for the commit f31b187 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@yakutovicha I will take a closer look at this, please wait before merging, thanks.
Although there is an issue caused by using threading with daemon as we discussed offline, I propose we ignore it for the moment.
@unkcpz can you elaborate on this? Is this problem present also on master or only on this PR? If the latter, we should not merge this. What aiida-core version have you seen it? I think there have been some issues with the daemon for version < 2.2.2
tbh I am not very happy about the code here (and I realize I was the one pushing for this change, my apologies). The circular nature of the
value
andprocess
traits makes the code very confusing and error prone imo. My original idea was to have a one-way flow fromprocess
tovalue
, but that is not great either since they would not be in sync which might lead to bugs as well.
That is fine with me. But in that case, we must proceed with the backward incompatible changes listed here.
@yakutovicha that is fine with me, since you anyway said we have currently control over all apps in the appstore.
Btw: the new test in this PR might be worthwhile merging.
I am travelling today back from Switzerland, should be available more tomorrow.
@unkcpz can you elaborate on this? Is this problem present also on master or only on this PR? If the latter, we should not merge this. What aiida-core version have you seen it? I think there have been some issues with the daemon for version < 2.2.2
The error is shown in https://github.com/aiidalab/aiidalab-widgets-base/pull/471#pullrequestreview-1357821001 and can be reproduce with the latest docker stack which running with aiida-core 2.2.2.
It is not this PR which introduces the issue, it was there already. The tests will not failed but the error messages popped up showing the DB session is not properly shut down after the query. @yakutovicha and I suspect this might be the issue that causes the memory leak of the container we run for the moment.
Seems we don't want to continue on this route. So @yakutovicha can you update the PR to leave only the test as @danielhollas suggested?
Seems we don't want to continue on this route. So @yakutovicha can you update the PR to leave only the test as @danielhollas suggested?
yep, I just opened PR #478 with the test only.
fixes #426