aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

ProcessCallStackWidget: Fix calc_info signature for aiida-core 2.4 #491

Closed danielhollas closed 1 year ago

danielhollas commented 1 year ago

One of the unit tests started failing after aiida-core 2.4 release. (yay for tests! :tada:) Turns out this change was the culprit.

https://github.com/aiidateam/aiida-core/pull/6056

Fixes #492

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (0d9fee6) 79.42% compared to head (2bee4e0) 79.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #491 +/- ## ========================================== + Coverage 79.42% 79.45% +0.02% ========================================== Files 27 27 Lines 3728 3728 ========================================== + Hits 2961 2962 +1 + Misses 767 766 -1 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `79.45% <100.00%> (+0.02%)` | :arrow_up: | | python-3.8 | `79.48% <100.00%> (+0.02%)` | :arrow_up: | | python-3.9 | `79.48% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [aiidalab\_widgets\_base/process.py](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL3Byb2Nlc3MucHk=) | `78.58% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.