search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Remove dynamic version attribute from setup.cfg #493

Closed danielhollas closed 1 year ago

danielhollas commented 1 year ago

Dynamic version attributes are not yet supported in the aiidalab package. Since AWB is currently an App, and not just a library, we need to use a static version.

Here's what you currently get for AWB 2.0.0

$ aiidalab list
App name               Version              Path
---------------------  -------------------  ---------------------------------------
aiidalab-widgets-base  AppVersion.UNKNOWN•  /home/jovyan/apps/aiidalab-widgets-base
home                   v23.03.1             /home/jovyan/apps/home
danielhollas commented 1 year ago

@yakutovicha ah, interesting. My outputs is what I see is when I pull master for AWB development. In other words, when the app is checked out at a commit that is not tagged.

So I don't know if this is worth fixing (but I guess it does not hurt either since we're using bumpver anyway). What do you think @yakutovicha

yakutovicha commented 1 year ago

@yakutovicha ah, interesting. My outputs is what I see is when I pull master for AWB development. In other words, when the app is checked out at a commit that is not tagged.

The output makes sense then

So I don't know if this is worth fixing (but I guess it does not hurt either since we're using bumpver anyway). What do you think @yakutovicha

Honestly, I will probably forget about this and one day revert to what it was (if no one will stop me), as it is a bit shorter and somewhat more automatic. So I am slightly negative.

But if you want this change, go ahead - it won't hurt either.

danielhollas commented 1 year ago

I'll close this, not worth the churn. Thanks!