aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Make notebook tests less flaky #497

Closed danielhollas closed 1 year ago

danielhollas commented 1 year ago

We now wait until the Appmode loading gif disappears. We've been using this strategy in my app and in QeApp for a while and it seems to work well.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3f15948). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head d23416d differs from pull request most recent head 0f72804. Consider uploading reports for the commit 0f72804 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #497 +/- ## ========================================= Coverage ? 79.63% ========================================= Files ? 27 Lines ? 3752 Branches ? 0 ========================================= Hits ? 2988 Misses ? 764 Partials ? 0 ``` | Flag | Coverage Δ | | |---|---|---| | python-3.10 | `79.63% <0.00%> (?)` | | | python-3.8 | `79.67% <0.00%> (?)` | | | python-3.9 | `79.67% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielhollas commented 1 year ago

Ugh, looks like new Cython broke tests here as well: scikit-learn failed to build. I guess we should upgrade it.

danielhollas commented 1 year ago

@unkcpz this one is now ready.