Closed danielhollas closed 11 months ago
Patch coverage: 81.39%
and project coverage change: +0.04%
:tada:
Comparison is base (
aec8f87
) 79.46% compared to head (15494bf
) 79.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
However, later I am introducing the https://github.com/aiidateam/aiida-core/pull/6083 which will revert things to Dropdown. Then, there will be firecrest. It would take some more work to adopt them, though.
Ah, that's good to know. I also found out that the transport value is indeed passed to the computer setup function, I did not notice that before since it is accessed via getattrs
I would only request to keep the self.transport.value = "core.ssh" line and set the original value to core.ssh too. It was issued later on. Also, settings downloaded from the code database override the value. Herein, SSH as the value may cause trouble.
Another good point. As a side note, I am not a fan of this design, core.ssh
is not very user friendly, we're essentially exposing the user to internal AiiDA details. But that's for another time...
Given all of the above, I've reverted the original change and instead fix the underlying bug and made the core.local
transport work. I also added a unit test. @yakutovicha could you please test locally?
Great, thanks @yakutovicha!
It is not clear whether AiiDA Computer setup ever worked with any transport other than SSH, but in any case the widget is clearly designed with SSH in mind so unless a clear need is found we can simply remove the 'Transport type" dropdown. Note the the value of this widget has not been used anywhere in the code, which is telling.
The localhost computer is setup in the AiiDAlab Docker image by default, and in the unlikely case that another one needs to be setup, such user probably knows how to set it up via verdi command line interface.
Fixes #417