aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

StructureViewer Download tab: pass file format explicitly #504

Closed danielhollas closed 11 months ago

danielhollas commented 12 months ago

The change in #501 broke my application because it changed the file_format traitlet, on which I was relying.

I could update my app but it would be a bit complicated to support both old and new version, so I thought I'll make a small change here if that is okay with you @yakutovicha.

Incidentally, I also fixed a small bug where _prepare_payload function was called twice.

codecov[bot] commented 12 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (413c26c) 79.42% compared to head (60923a2) 79.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #504 +/- ## ======================================= Coverage 79.42% 79.42% ======================================= Files 27 27 Lines 3757 3757 ======================================= Hits 2984 2984 Misses 773 773 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.42% <0.00%> (ø)` | | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.46% <0.00%> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.46% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [aiidalab\_widgets\_base/viewers.py](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#diff-YWlpZGFsYWJfd2lkZ2V0c19iYXNlL3ZpZXdlcnMucHk=) | `70.93% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.