Closed danielhollas closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
ccfcf80
) 79.97% compared to head (dcdc755
) 79.92%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@unkcpz can you take a look? Would be nice to get this to 2.1 version so we have more confidence in our test suite.
Sure, I'll take it a look ASAP. In case you get more grumpy ;)
Sure, I'll take it a look ASAP. In case you get more grumpy ;)
Haha :smiling_face_with_tear: That when I tried (ultimately unsuccessfully) to get rid of some warnings coming from Selenium.
@unkcpz the code is good to go from my side. However, I have not yet manually tested that I did not break anything (although we have better and better tests). If you could help with that that would be appreciated. The main thing is to test the viewer()
since that has seen to most change.
I gave it a test on the QE app and it didn't break anything yet.
I'll make an beta release for AWB and do a thorough test on the rc
release in QEapp.
Cool, let's go for it, I will also test it in my app. The other PRs should merge the master now to ensure that no new warnings are introduced. CC @yakutovicha
Fixes #490.
TODO: Test things
I extracted some fixes that were actual bugs into separate PRs, #512 and #513.
This is blocked until they are mergedNow unblocked