Closed danielhollas closed 11 months ago
Patch coverage: 100.00%
and project coverage change: +0.04%
:tada:
Comparison is base (
2c29a9e
) 79.31% compared to head (71fb812
) 79.35%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@danielhollas please re-request my review when the PR is ready.
Turns out we were not closing the
.ssh/config
file, which was uncovered by looking at pytest warnings when running unit tests in #509.Also, the existing parsing logic was very brittle and did not take into account a possible variations (e.g. capitalization, extra white space etc.) So I switched to a proper parser from aiida-core, that we already use in this file anyway. Here's a good page describing the syntax of ssh config file. https://www.ssh.com/academy/ssh/config
I also discovered other possible bugs in the code, left them as TODO for future PRs and opened #516 to track them.