Closed unkcpz closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ebc7120
) 79.92% compared to head (18496a2
) 79.92%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?
Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?
Looking at the screenshots they are still loading. Strange, maybe the github runners are slow today? I wonder if we could speed the loading somehow, perhaps by making the notebook simpler or split it up into multiple notebooks if possible?
For now I'd try to increase the wait that wait for the busy icon to disappear even further, from 120s to 240s or something like that?
from 120s to 240s or something like that?
Okay, thanks. I give it a try.
Nice!
The smoke test in https://github.com/aiidalab/aiidalab-widgets-base/pull/511 failed but because of structure notebooks. From the screenshots the notebook is still loading. I guess the
timeout=10
is too short?