aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Fix/xx/increase timeout of di test #529

Closed unkcpz closed 8 months ago

unkcpz commented 8 months ago

The smoke test in https://github.com/aiidalab/aiidalab-widgets-base/pull/511 failed but because of structure notebooks. From the screenshots the notebook is still loading. I guess the timeout=10 is too short?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ebc7120) 79.92% compared to head (18496a2) 79.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #529 +/- ## ======================================= Coverage 79.92% 79.92% ======================================= Files 27 27 Lines 3815 3815 ======================================= Hits 3049 3049 Misses 766 766 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/529/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.92% <ø> (ø)` | | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.95% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `79.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

unkcpz commented 8 months ago

Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?

danielhollas commented 8 months ago

Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?

Looking at the screenshots they are still loading. Strange, maybe the github runners are slow today? I wonder if we could speed the loading somehow, perhaps by making the notebook simpler or split it up into multiple notebooks if possible?

For now I'd try to increase the wait that wait for the busy icon to disappear even further, from 120s to 240s or something like that?

unkcpz commented 8 months ago

from 120s to 240s or something like that?

Okay, thanks. I give it a try.

unkcpz commented 8 months ago

Nice!