aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Allow set key_filename/key_policy in computer configure #537

Closed unkcpz closed 8 months ago

unkcpz commented 8 months ago

There are some values for authinfo setting that are hardcoded. It should be able to be set from computer-configure dict. This is required by the CSCS MFA configure setup. The key filename is set in configure to cscs-key but not passed to the AuthInfo.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (140172a) 85.83% compared to head (e0edaa5) 85.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #537 +/- ## ========================================== + Coverage 85.83% 85.88% +0.04% ========================================== Files 27 27 Lines 4610 4618 +8 ========================================== + Hits 3957 3966 +9 + Misses 653 652 -1 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/537/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `85.88% <100.00%> (+0.04%)` | :arrow_up: | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `85.91% <100.00%> (+0.04%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `85.91% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.