search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Fix failed resources widget #544

Closed unkcpz closed 7 months ago

unkcpz commented 7 months ago

Test failed because there is no QuantumESPRESSO-7.2 in resource registry, we remove it in aiidateam/aiida-resource-registry@a6b1dc5. This commit should fix it.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aba0bdb) 87.12% compared to head (4a2406b) 87.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #544 +/- ## ======================================= Coverage 87.12% 87.12% ======================================= Files 27 27 Lines 4643 4643 ======================================= Hits 4045 4045 Misses 598 598 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.12% <100.00%> (ø)` | | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.15% <100.00%> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.15% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

unkcpz commented 7 months ago

I admit that the unit test relying on the other package (aiida-resourec-registry in this case) is not a good idea. I was thinking of creating a fixture for it but it can be outdated if the aiida-resource-registry is updated. Probably the best solution is to create an object for the test with validate it with the schema on the aiida-resource-registry, then the test will decouple from it.