search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Remove deprecated load_documentation_profile for doc build #555

Closed unkcpz closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cfb01eb) 87.12% compared to head (56fc7e6) 87.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #555 +/- ## ======================================= Coverage 87.12% 87.12% ======================================= Files 27 27 Lines 4646 4646 ======================================= Hits 4048 4048 Misses 598 598 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/555/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/555/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.12% <ø> (ø)` | | | [python-3.8](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/555/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.16% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/555/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.16% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 5 months ago

I am confused. Why the does the doc build depend on aiida-core profile?

unkcpz commented 5 months ago

Haha, you are right! The profile was for API build (see discussion https://github.com/aiidateam/aiida-core/pull/6231), but it is not needed anymore. I remove it and the build still passed.