search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Add test to latest and oldest supported aiida-core #558

Closed unkcpz closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.07%. Comparing base (8808a3c) to head (4bbb55d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #558 +/- ## ======================================= Coverage 87.07% 87.07% ======================================= Files 27 27 Lines 4649 4649 ======================================= Hits 4048 4048 Misses 601 601 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/558/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.07% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

unkcpz commented 4 months ago

The unittest with python==3.9 and aiida-core==2.1.2 failed because of PyYAML issue https://github.com/yaml/pyyaml/issues/723

So in fact the oldest support version is 2.2.0 where the PyYAML bumped to ~6.0, https://github.com/aiidateam/aiida-core/commit/09adc188e46d5d2265a921f6726d94d19a72d93b

I think we can make the oldest support aiida-core version to be v2.2.0, @danielhollas what do you think?

danielhollas commented 4 months ago

Ugh, that's annoying. I'll take a look, thanks!

danielhollas commented 4 months ago

I checked on Dockerhub and we released an image with aiida 2.2 10 months ago. So let's just test with this version and not waste too much time on this. Can always improve this in the future if needed.

unkcpz commented 4 months ago

Thanks for the review @danielhollas