Open yakutovicha opened 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.50%. Comparing base (
8808a3c
) to head (1340e40
). Report is 39 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @yakutovicha ,
When integrated with awb's StructureManager the control icons look weird:
this is fixed. Also the undo
and redo
buttons hidden using the guiConfig
parameter.
Besides, the text of the dropdown in the control was wrong; this has also been fixed.
When uploading a new structure with the StructureManager, the weas viewer doesn't show it.
This is also fixed.
Please test it again, and see is there any update required from the weas side.
Enter the folder and switch to the feature/integrate-with-structuremanager-widget branch. Pip install it: pip install --user -e .
now it also needs to run npm
to install weas-widget locally
npm install
npm run build
pip install -e .
Requires https://github.com/superstar54/weas-widget/pull/22.
Here is the way to test it:
~/apps/
foldercd aiidalab-widgets-base
feature/weas-viewer-integration
branchpip install --user -e .
feature/integrate-with-structuremanager-widget
branch.pip install --user -e .
File Manager
in AiiDAlab and enter theapps/aiidalab-widgets-base/notebooks
folderstructures.ipynb
and execute its cells.Problems:
When integrated with awb's![image](https://github.com/aiidalab/aiidalab-widgets-base/assets/13118485/5d0980f4-7708-4d0c-bfa0-1a90efb4ab4c)
StructureManager
the control icons look weird:When uploading a new structure with the
StructureManager
, the weas viewer doesn't show it. The only way for it to work is to launch a viewer in a separate cell and execute it: