search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Only trigger publish on release.published event #572

Closed danielhollas closed 4 months ago

danielhollas commented 4 months ago

We noticed that making a release triggered multiple different release events: created, prereleased, published. So we need to tweak the workflow file so that the workflow only run for the release.publish event.

https://github.com/aiidalab/aiidalab-widgets-base/actions?query=event%3Arelease

Per GHA docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

EDIT: I am not sure if the fix here works, need to test on another repo. Marking as draft for now

EDIT2: Never mind, turns out I can't read the docs properly. I fixed the syntax and checked on my repo, this seems to work correctly now.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.07%. Comparing base (cd2face) to head (84aae31).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #572 +/- ## ======================================= Coverage 87.07% 87.07% ======================================= Files 27 27 Lines 4649 4649 ======================================= Hits 4048 4048 Misses 601 601 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/572/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.07% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `87.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 4 months ago

Yep! On my todo-list for today or Wednesday. Thanks!