aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

Bump version v2.2.0a0 -> v2.2.0a1 #585

Closed danielhollas closed 2 months ago

danielhollas commented 2 months ago

I want to get a fix in #350 in a new alpha version.

Note, I've specifically opened this PR from my fork, to test @unkcpz observation that the tag from fork will not get transferred to origin when the PR is merged (which is most likely what will happen). In that case, I'll create the tag manually after merge.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.17%. Comparing base (cc4291b) to head (826ad43). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #585 +/- ## ========================================== + Coverage 87.07% 96.17% +9.10% ========================================== Files 27 11 -16 Lines 4649 1177 -3472 ========================================== - Hits 4048 1132 -2916 + Misses 601 45 -556 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/585/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/585/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.17% <ø> (+9.10%)` | :arrow_up: | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/585/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.17% <ø> (+9.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 2 months ago

Cheers @superstar54

Indeed, the tag was not transferred from the forked repo, I've created it manually when making a release. It's nice that you can specify a specific commit for the tag.

image

unkcpz commented 2 months ago

It's nice that you can specify a specific commit for the tag.

Now I am confusing again. If the tag has to be create manually, it entirely fallback to the strategy that create the tag to trigger the deployment (upload to PyPI). So in the end, I think we should use create tag to make the release (I think it is also quite standard, no?) What we learned and can added is using this CI review and approve, I don't remember where it is implemented and I am confused why I didn't see it now.

danielhollas commented 2 months ago

Sorry for confusion. I think this is better to discuss in person (unfortunately I will not be able to make it to today's meeting).

tl;dr IMO the solution here is to always push the release branches to origin, and not forked repo. In fact in the guide on the wiki I've explicitly written that one should always clone a fresh repository to make a release, and I stand by this, because this avoids all kinds of issues:

Also, in case of python packages published on PYPI, pushing the release branch to origin allows you to publish the release on TestPyPI first, where you can verify the package before the actual release. This is not possible to do from fork due to missing PYPI secrets.

unkcpz commented 2 months ago

pushing the release branch to origin allows you to publish the release on TestPyPI first, where you can verify the package before the actual release.

This is a good point and I totally agree. So we can either always ask to run bumpver from a newly cloned folder or add a option to bumpver to push to a certain remote. Let's discuss in person.