search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Run test publish workflow on push to release/ branches #594

Closed danielhollas closed 6 months ago

danielhollas commented 7 months ago

I noticed when releasing version 2.2.0 that the test publish workflow was not triggered on the PR in #593. This was my mistake: At some point I changed the triggering event from push to pull_request. However, the branches filter that we use so that the test-publish is only run on release branches, has a different semantic meaning for pull_request event --- it specifies the target branch, not the branch that is being merged.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.21%. Comparing base (1bba240) to head (3e60c9b). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #594 +/- ## ======================================= Coverage 96.21% 96.21% ======================================= Files 11 11 Lines 1188 1188 ======================================= Hits 1143 1143 Misses 45 45 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/594/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 7 months ago

@yakutovicha can you take a look?

Note that the publish workflow as specified here was there basically as is before I made any changes, the idea that you can inspect a release by first releasing on TestPyPI, where you can then inspect the package. But practically this couldn't really be used with bumpver, since you'd always push to master. (not saying which is better, just providing context).

danielhollas commented 6 months ago

Going to merge this, since we need to release a patch version.