search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
6 stars 17 forks source link

remove underscore in function call #597

Closed AndresOrtegaGuerrero closed 2 months ago

AndresOrtegaGuerrero commented 2 months ago

This address #581

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.21%. Comparing base (1bba240) to head (7252cb8). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #597 +/- ## ======================================= Coverage 96.21% 96.21% ======================================= Files 11 11 Lines 1188 1188 ======================================= Hits 1143 1143 Misses 45 45 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/597/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superstar54 commented 2 months ago

@AndresOrtegaGuerrero, the pre-commit test fails; please fix it before merging.

danielhollas commented 2 months ago

Ping @sphuber I am a bit surprised by the fact that calcfunction inputs cannot start with an underscore. Is that a known behaviour?

AndresOrtegaGuerrero commented 2 months ago

@AndresOrtegaGuerrero I guess the precommit fail comes from ruff complaining about unused function argument, so you're going to have to add noqa comment.

It's quite possible I introduced this bug when I was switching linters to ruff, my apologies if that is the case. Ideally we should have a test case for this, but that can wait for a follow up PR.

Thank you @danielhollas ! Have a look

danielhollas commented 2 months ago

Indeed, I introduced this problem when switching to ruff in commit

63332a6a4c1681132ce69bf68f68347021f93cc8

Thanks for finding it and a fix.