search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Bump version v2.2.0 -> v2.2.1 #598

Closed danielhollas closed 6 months ago

danielhollas commented 6 months ago

@superstar54 I am assuming you want to make a new AWB release to include #597? Is there something else that needs fixing?

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.21%. Comparing base (1bba240) to head (9834dad). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #598 +/- ## ======================================= Coverage 96.21% 96.21% ======================================= Files 11 11 Lines 1188 1188 ======================================= Hits 1143 1143 Misses 45 45 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/598/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superstar54 commented 6 months ago

Thanks for reaching out, @danielhollas. @AndresOrtegaGuerrero and I recently discussed the possibility of releasing a new version of AWB, especially considering the inclusion of #597. While we see the value in a new release, AWB 2.2.0 was just launched, and we didn't want to impose by requesting another so soon. We truly appreciate your initiative to consider another release and are grateful for your support.

superstar54 commented 6 months ago

Is there something else that needs fixing?

Nothing else from my side. @AndresOrtegaGuerrero , do you have anything in mind?

AndresOrtegaGuerrero commented 6 months ago

Is there something else that needs fixing?

Nothing else from my side. @AndresOrtegaGuerrero , do you have anything in mind?

No, thank you @danielhollas !

superstar54 commented 6 months ago

Hi @danielhollas , it seems that the AWB 2.2.1 has not been officially released.

danielhollas commented 6 months ago

@superstar54 thank you for the reminder, it is released now. https://pypi.org/project/aiidalab-widgets-base/

While we see the value in a new release, AWB 2.2.0 was just launched, and we didn't want to impose by requesting another so soon.

No problem at all, this is what what patch releases are for, and this bugfix seemed important.