search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

CI fix: Test on push to master branch, not main! #611

Closed danielhollas closed 5 months ago

danielhollas commented 5 months ago

We haven't been running CI on pushes to master since #573, whoops! My bad. :cry:

I also needed to pin the ASE version since the recently released version 3.23 broke one of our tests that hardcodes a binary output from ase.Atoms.write. I opened #612 with more details.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (7c9a3ef) to head (b46b963). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #611 +/- ## ========================================== - Coverage 96.21% 96.19% -0.02% ========================================== Files 11 11 Lines 1188 1183 -5 ========================================== - Hits 1143 1138 -5 Misses 45 45 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/611/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/611/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.19% <ø> (-0.02%)` | :arrow_down: | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/611/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `96.19% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielhollas commented 5 months ago

Going to merge this to unblock the other PRs.

unkcpz commented 5 months ago

Ha, interesting~ I am wondering anyelse master we still have in aiidalab?

danielhollas commented 5 months ago

I am not aware of any.