search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Adding support for `orm.Containerized` codes #617

Closed mikibonacci closed 3 months ago

mikibonacci commented 3 months ago

This is obtained using the AiidaCodeSetup().code_setup attribute.

I am not sure is the better way, as we should also provide the possibility to change the image_name and the engine_command via the GUI. However, I think that for now this is acceptable, as the containerized codes are mainly set up by using the information on the aiida-resource-registry repo. Actually, it is a really new thing and for now only the phonopy@merlin-cpu is defined.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (d8b7e71) to head (774a2a2). Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
aiidalab_widgets_base/computational_resources.py 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #617 +/- ## ========================================== - Coverage 83.65% 83.62% -0.03% ========================================== Files 16 16 Lines 3511 3517 +6 ========================================== + Hits 2937 2941 +4 - Misses 574 576 +2 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/617/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `83.62% <71.42%> (-0.03%)` | :arrow_down: | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `83.66% <71.42%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.