Open edan-bainglass opened 1 month ago
Attention: Patch coverage is 79.01235%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 83.64%. Comparing base (
de5f0cc
) to head (93d2986
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@superstar54 @unkcpz can you guys have a look at the failed tests? I don't see how my changes could suddenly trigger the following error, which is failing several structure-related tests!
DeprecationWarning: dict interface (SpglibDataset['international']) is deprecated.Use attribute interface ({self.__class__.__name__}.{key}) instead
Hi @edan-bainglass , spglib released a new version yesterday. Apparently, it drops support for some old API.
I just created an issue on this: https://github.com/aiidalab/aiidalab-widgets-base/issues/625
@superstar54 I see. So we need to update on our end? I take it this is unrelated to my PR. I would rebase on top of an update PR once that's in?
Regarding an spglib
update PR, do we need it? Can we instead pin to <2.5.0?
Regarding an spglib update PR, do we need it? Can we instead pin to <2.5.0?
No idea yet.
You can just add the DeprecationWarning to the list of ignored warnings in pyproject.toml
(We have configured pytest so that it turns any warnings into errors, maybe we should change it)
Based on #624
This PR adds info box widgets to provide in-app information to users