Closed danielhollas closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.61%. Comparing base (
de5f0cc
) to head (34bbe53
). Report is 10 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Notebook failures are unrelated to this PR.
@edan-bainglass does this change make sense to you?
In #621 I've unpinned traitlets dependency from
traitlets==5.9.0
totraitlets~=5.9
. What I did not realize, and we found out the hard way in aiidalab/aiidalab-docker-stack#494,traitlets>=5.10
break the jupyter notebook version in the current AiiDAlab image.As aiidalab/aiidalab-docker-stack#494 showed as, it is really not good if traitlets dependency is installed outside of the conda enviroment (i.e. to ~/.local) as it may break the jupyter notebook. Here we downgrade the minimum traitlets version back to 5.4.
(NOTE: That the original motivation to upgrading to 5.9 was performance, I believe it is better if we upgrade directly in the image). I'll open a separate issue for discussion, this is just a hotfix.
Fixes aiidalab/aiidalab-docker-stack#494