Adding HYBRID/NONLOCAL keywords + a bug fix

aiidaplugins / aiida-crystal17

A plugin for AiiDA, to run the CRYSTAL17 code

https://aiida-crystal17.readthedocs.io

GNU Lesser General Public License v3.0

5 stars 4 forks source link

Closed ezpzbz closed 1 year ago

ezpzbz commented 3 years ago

This PR aims to address the issue #37

During the testing I noticed that the order of EXCHANGE and CORRELAT is wrong and it is also fixed in this PR.

ezpzbz commented 2 years ago

Hi @chrisjsewell May you please check this PR :)

chrisjsewell commented 2 years ago

Ah yes, thanks for pinging me

ezpzbz commented 2 years ago

Thanks @chrisjsewell for comments. I've tried to address them. Please let me know if there is anything else I can do. Cheers

ezpzbz commented 2 years ago

Hi @chrisjsewell I just noticed we have not finalized this PR. Please let me know if there is any remaining changes needed on my side. Cheers

ezpzbz commented 1 year ago

Hi @chrisjsewell Just noticed we have not taken this PR forward. Shall we?

ezpzbz commented 1 year ago

I'm closing this PR due to inactivity. Will keep changes in my fork.