aiidaplugins / aiida-lammps

LAMMPS plugin for AiiDA
https://aiida-lammps.readthedocs.io
MIT License
22 stars 14 forks source link

116 dependabot tests failing for python38 #119

Closed JPchico closed 5 months ago

JPchico commented 5 months ago

Fixing an issue in which the newer versions of jsonschema were causing the tests to fail.

Have pinned the jsonschema dependency and removed some leftover python 3.8 tests and mentions.

Fixes #116

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.51%. Comparing base (2e3bfce) to head (6f1458e).

:exclamation: Current head 6f1458e differs from pull request most recent head 1e84f30. Consider uploading reports for the commit 1e84f30 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #119 +/- ## ======================================== Coverage 85.51% 85.51% ======================================== Files 19 19 Lines 1622 1622 ======================================== Hits 1387 1387 Misses 235 235 ``` | [Flag](https://app.codecov.io/gh/aiidaplugins/aiida-lammps/pull/119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidaplugins) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/aiidaplugins/aiida-lammps/pull/119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidaplugins) | `85.51% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidaplugins#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JPchico commented 5 months ago

Hi @sphuber I'll merge this even if the codecov is failing since this seems to be an upstream issue with the action.