search

aiidateam / aiida-code-registry

Registry of simulation codes and computers for easy setup in AiiDA.
2 stars 11 forks source link

add generate-json in pre-commit action #69

Closed superstar54 closed 1 year ago

superstar54 commented 1 year ago

Run the generate_json.py in the pre-commit action, therefore checking all the setup info of computers/codes.

superstar54 commented 1 year ago

@unkcpz Thanks, I have removed the unnecessary lines and merged the test_generate_json job into the pre-commit job. Please review.

unkcpz commented 1 year ago

As discuss with @superstar54 offline, better to keep separate actions for pre-commit and test_generate_json.

superstar54 commented 1 year ago

@unkcpz the test_generate_json is now separated from pre-commit.

unkcpz commented 1 year ago

I'll merge this anyway since it is the known error for generating JSON.