search

aiidateam / aiida-common-workflows

A repository for the implementation of common workflow interfaces across materials-science codes and plugins
https://aiida-common-workflows.readthedocs.io
MIT License
52 stars 32 forks source link

Abinit validation protocol #309

Closed azadoks closed 1 year ago

azadoks commented 1 year ago

I'm working here with a clean slate on addressing the comments from #287

sphuber commented 1 year ago

pre-commit breaking your balls huh, @azadoks . Now that the tests pass, is this still a draft or can it be reviewed?

azadoks commented 1 year ago

pre-commit breaking your balls huh, @azadoks . Now that the tests pass, is this still a draft or can it be reviewed?

Yeah, christ that thing is picky. All good for review I think. @sponce24, maybe you can look it over too (especially the protocol).

bosonie commented 1 year ago

@azadoks I assume this one is the good PR, right? and #287 should be discarded?

azadoks commented 1 year ago

@bosonie Should be ready to merge now, I think?

bosonie commented 1 year ago

@azadoks I see that some VASP files are changed. Is this correct? Not an expert of github so maybe @sphuber can help?

sphuber commented 1 year ago

Seems to be a rebase-botch. Have seen those before with @azadoks ;) will fix it

sphuber commented 1 year ago

There that should have done it. I will go ahead and merge this then