aiidateam / aiida-common-workflows

A repository for the implementation of common workflow interfaces across materials-science codes and plugins
https://aiida-common-workflows.readthedocs.io
MIT License
52 stars 32 forks source link

Recently added YAML formatter leads to crash with cp2k #336

Closed bosonie closed 8 months ago

bosonie commented 8 months ago

The changes introduced in #331 are leading to wrong inputs for cp2k. In the cp2k protocols (src/aiida_common_workflows/workflows/relax/cp2k/protocol.yml) there are several ON, OFF. In the previous formatting 'ON' and 'OFF' were with quotes and the plugin was working correctly. In the new formatting, the quotes are removed and apparently ON and OFF without quotes are interpreted by the reader and transformed in True and False. This leads to cp2k calculation inputs with True and False instead of ON and OFF. The program does not recognize the values and crashes.

To reproduce it, just acwf launch relax cp2k making sure to be in the main branch. Of course you need a configured code pointing to a cp2k executable. Inspecting the aiida.inp of the generated calculation, you can see the True and False instead of the ON and OFF.

@sphuber and @yakutovicha are probably the right people to find a solution.