search

aiidateam / aiida-common-workflows

A repository for the implementation of common workflow interfaces across materials-science codes and plugins
https://aiida-common-workflows.readthedocs.io
MIT License
52 stars 31 forks source link

Devops: Exclude CP2K protocol YAML from format hook #338

Closed sphuber closed 8 months ago

sphuber commented 8 months ago

Fixes #336

The protocol file includes a couple of instances of ON and OFF that are intended as literal string values. The formatter strips quotes from strings without spaces as it is not required in YAML. However, in YAML, the ON and OFF values are also aliases for true and false and so the formatter standardizes these values to true and false. The file is excluded from the formatter for that reason.

sphuber commented 8 months ago

@bosonie Thanks for testing. This should fix this problem, but since I cannot test CP2K I cannot be sure it caught everything. It would be great if you could give this another spin.