presubmit fails in verdi run because Aiida can't parse the job info

cbehren commented 7 months ago

Describe the bug

If I use the login_shell option on my Debian machine and the local scheduler, running any CalcJob through verdi run fails because Aiida fails to interpret the output of the query for jobs, here:

https://github.com/aiidateam/aiida-core/blob/b7e59a0dbc0dd629be5c8178e98c70e7a2c116e9/src/aiida/schedulers/plugins/direct.py#L230-L231

I figured out this is because the stdout parsed there contains the output of the call to ps, but also the MOTD stuff (like the logo of my server).

The error leads to a failure of the presubmit script.

Steps to reproduce

I see this error e.g. in the beginner's tutorial on the Aiida doc page. I could overcome it by disabling login_shell.

Your environment

Operating system [e.g. Linux]: Debian 11 Bullseye
Python version [e.g. 3.7.1]: 3.11.0
aiida-core version [e.g. 1.2.1]: 2.5.1

sphuber commented 7 months ago

Does verdi computer test report an issue? I think it should.

cbehren commented 7 months ago

Ah, indeed. That gives me errors! I guess that resolves the issue. Thanks for the quick reply.

aiidateam / aiida-core