aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

Config: Revert checking of CWD for config directory location #6349

Closed sphuber closed 5 months ago

sphuber commented 5 months ago

In 1059b5f2d365e0f2ea4dea4d3c9343ce77829cfe the logic to determine the location of the configuration directory was modified to also check the hierarchy of the current working directory for an existing directory. After discussion, it seems that this change is more impactful than anticipated and needs to be discussed in more depth before being released. Therefore the change is reverted for now.

sphuber commented 5 months ago

I see the definition of an AiiDA instance is still kept to be the .aiida folder, but that's fine.

What part of the code/docs are you referring to here? I didn't literally revert the linked commit since the related code was refactored slightly after that and I wanted to keep some of those refactorings that didn't change any of the original behavior. So I think the original behavior and language is restored, but I might have missed something during the manual revert.

mbercx commented 5 months ago

The first sentences here, that define an AiiDA instance:

https://aiida--6349.org.readthedocs.build/projects/aiida-core/en/6349/howto/installation.html#isolating-multiple-instances

Compare this to the current documentation:

https://aiida.readthedocs.io/projects/aiida-core/en/stable/howto/installation.html#isolating-multiple-instances

In fact, now that I read it in more detail, the description of how to (currently) isolate AiiDA instances is also missing, so perhaps we should do a proper revert of the docs as well indeed.

sphuber commented 5 months ago

In fact, now that I read it in more detail, the description of how to (currently) isolate AiiDA instances is also missing, so perhaps we should do a proper revert of the docs as well indeed.

Sure fine, I reverted part of the docs, removing the CWD from the table, but forgot that I had significantly rewritten it.

mbercx commented 5 months ago

Thanks @sphuber, everything looks in place again now! Good to go for me 🚀