Closed danielhollas closed 1 month ago
The SSH error was handled in #6372 and was not really of any consequence.
I have renamed the issue to reflect the maining issue which is separate. Essentially, the mentioned code models declare the fields computer
and filepath_file
, with the types str
. However, they have a serializer that converts them to a Computer
instance and a pathlib.Path
instance. This is allowed by pydantic but it does warn that the return type of the custom serializer does not match the type declaration. The reason for the type change is that the return type is easier to deal with in the Python API, so it is convenience for the user. I think I only added a single type instead of a Union
because the dynamic CLI verdi code create
needs to determine the option type based on the type annotation and click
does not support unions, so it has to choose one, which currently emits a warning as well. But I guess we can simply silence this warning.
Describe the bug
I noticed a couple of warnings / errors in the nightly tests log (in "Setup environment" step), not sure if those are pertinent to anything, see full log